Some error messages are wrong

[sxw]

In trying to track down some other issues, I've ended up playing around in the SM code rather more than intended.

There seem to be some RFC compliance issues with some of the error messages that are returned, which seem to not follow XMPP-IM section 11.

In particular (section numbers are from the RFC):

11.2 - If the associated user account doesn't exist the behaviour should be: PRESENCE: ignore IQ: must return <service-unavailable> MESSAGE: should return <service-unavailable>

Currently, we do ignore, <item-not-found>, <item-not-found>, respectively, so both of the error responses have the wrong code.

11.3 If the JID has a resource, but there's no resource that matches, we should do: PRESENCE: ignore IQ: must return <service-unavailable> MESSAGE: send to user@domain Currently, we do ignore, <recipient-unavailable>, send to user@domain The error response has the wrong code, but the rest of the behaviour is correct

Is it worth producing a patch to fix these error codes?

[smoku]

It is always worth producing bugfixes.

[sxw]

Change error returns to match those in XMPP-IM

[sxw]

On more - in mod_iq_vcard.c

[sxw]

Couple of patches attached. The Trac patch browser seems to miss the fix to sm/dispatch.c, but it's there in the uploaded file.

[smoku]

Applied the first patch. The second duplicates first chunk of first.

[smoku]

(In [248]) XMPP compatibility fixes. References #92

[smoku]

Closing as there are no more related fixes.

Please reopen with new patches.