Event messages get saved in queue

[smoku]

It seems that messages that have no content but just iq:event data still get saved in the queue. I have a couple of people in my roster who seem to be spewing events at me. If I'm online for longer than a day, these events fill my queue, causing sm to spin forever when I log in, trying to deliver them. This eventually kills the box.

mod_offline should probably only save messages if they actually have content in them.

------- Comment #3 From Stephen Marquard 2005-02-19 14:36 [reply] -------

mod_offline could filter messages like this (example from JEP-0022):

RECV: <message

from='romeo@…' to='juliet@…/balcony'>

<x xmlns='jabber:x:event'>

<offline/> <id>message22</id>

</x>

</message>

i.e. <message> with the only element being <x xmlns='jabber:x:event'>.

However, I'm still a bit lost as to what the underlying issue is - why a large queue should cause sm to use high cpu. One related bug was fixed before 2.0s6 (http://www.marquard.net/jabber/patches/patch-sm-offline-event).

I tested creating an offline queue of 30,000 messages (with mysql storage) and then logging in the user, which made the client PC somewhat unhappy, but the server was fine (short spike in sm cpu use, significant spike in sm mem use, but then cpu use back to normal).

[smoku]

Patch by Stephen Marquard <scm@…>

[smoku]

Already integrated into trunk.