s2s tries to reconnect constantly if disconnect with a stream error

[markdoliner]

To reproduce, log into your jabber server and send an IM to test (at) twitter.com. Then watch your s2s log file. It should print these three lines many times per second:

Tue Aug 19 00:25:30 2008 [notice] [99] [128.121.145.167, port=5269] outgoing connection for 'twitter.com'
Tue Aug 19 00:25:30 2008 [notice] [99] [128.121.145.167, port=5269] sending dialback auth request for route 'meebo.org/twitter.com'
Tue Aug 19 00:25:30 2008 [notice] [99] [128.121.145.167, port=5269] error: Stream error (<stream:error xmlns:stream='http://etherx.jabber.org/streams'><host-unknown xmlns='urn:ietf:params:xml:ns:xmpp-streams'/></stream:error>)

See the attached patch for one possible solution. I'll check it in if people like it.

[smoku]

In [690]: Detecting unrecoverable stream errors on establishing an outgoing s2s connection. Refs #244

[smoku]

The overral idea of the patch is good.

I reworked it a bit, to not be so strict about the error message format (search a substring instead of whole stanza comparison) and detect more error conditions.

Thanks Mark. :-)