jabberd2 solaris support patch

[patthoyts]

The current svn trunk jabberd2 code cannot be run on solaris 10. The problem is the following construct:

const char *s = NULL; ... sprintf(buffer, "blah blah %s blah", s)

In the jabberd2 code this is mostly a problem in calls to one of the debug functions. In glibc and Microsoft's C libraries passing a NULL pointer to a %s template argument causes "(null)" to be placed in the string. With the Solaris libc for whatever tedious reason this will segfault. As a result, for solaris support anything that might cause a NULL pointer to be passed to a *printf function requires something like:

sprintf(buffer, template, s?s:"(null)");

Attached is a patch that has fixed enough of these to get jabberd2 running on my Solaris 10 ultrasparc. I use gcc and configured with --enable-sqlite --enable-debug --enable-ssl --enable-sasl=gsasl so I've not fixed anything in the other storage interfaces.

[patthoyts]

svn diff

[smoku]

In [633]: Added missing %s argument in printf call. Refs #237

[smoku]

I don't really like the patch. It makes the code unreadable.

I think it needs to be fixed by rewriting log_debug() and _sx_debug() to use snprintf() and linking subst/snprintf.c implementation, or providing subst/printf.c implementation.