Ticket #2 (closed defect: fixed)

Opened 20 months ago

Last modified 20 months ago

storage_mysql.c sometimes increases buf an incorrect amount before writing to it

Reported by: smoku Owned by: smoku
Priority: major Component: storage
Version: 2.1 Keywords:
Cc: Tracforge_linkmap:
Blocking: Blocked By: 227

Description

I found two calls to the MYSQL_SAFE macro in sm/storage_mysql.c that don’t increase a buffer enough before writing to it. This results in writing to some memory that shouldn’t be written to. There were also a few places where the buffer was being increased more than needed. See the attached patch for fixes (the first hunk and the last hunk are the important two!)

Attachments

jabberd2_storage_mysql_buffer_size_fixes.diff (2.0 KB) - added by smoku 20 months ago.
Patch by Mark Doliner <mark@…>

Change History

Changed 20 months ago by smoku

Patch by Mark Doliner <mark@…>

Changed 20 months ago by smoku

  • status changed from new to closed
  • resolution set to fixed

(In [136]) Integrated mysql_buffer_size_fixes by Mark Doliner. Closes #2.

Changed 5 months ago by rek2

  • blockedby set to 227
Note: See TracTickets for help on using tickets.