Ticket #196 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

no 'to' xmpp-ping can segfault sm

Reported by: DeSnajpa Owned by: smoku
Priority: major Component: sm
Version: 2.1.23 Keywords:
Cc: Tracforge_linkmap:
Blocking: Blocked By:

Description

If a connected client sends xmpp ping without 'to', sm segfaults.

Attachments

ping.diff (470 bytes) - added by DeSnajpa 9 months ago.
sm.debug.txt (1.2 KB) - added by DeSnajpa 9 months ago.
gdb.sm.txt (2.1 KB) - added by DeSnajpa 9 months ago.

Change History

Changed 9 months ago by DeSnajpa

Changed 9 months ago by smoku

  • status changed from new to closed
  • resolution set to invalid

I don't see how no pkt->to would cause segfault.

The patch you provided touches pkt->from. But NULL in printf is not a problem - it just prints "(null)". And SM always fills 'from', so there is no way packet could have no 'from'.

Changed 9 months ago by DeSnajpa

Maybe I named it wrong, so I will post here my problems: Attached sm's debug and gdb's trace. Client sends: <iq id='473' type='get' xml:lang='en-US'><ping xmlns='urn:xmpp:ping'/></iq>

Changed 9 months ago by DeSnajpa

Changed 9 months ago by DeSnajpa

Changed 9 months ago by smoku

  • status changed from closed to new
  • resolution invalid deleted

Changed 9 months ago by smoku

  • status changed from new to closed
  • resolution set to fixed

in [571]: Removed debug that might cause segfault. Fixes #196.

Note: See TracTickets for help on using tickets.