Ticket #167 (closed defect: fixed)

Opened 11 months ago

Last modified 11 months ago

Patch: Attempt to fix 2 compile warnings

Reported by: markdoliner Owned by: smoku
Priority: major Component: General
Version: 2.1.17 Keywords:
Cc: Tracforge_linkmap:
Blocking: Blocked By:

Description

The warnings are:

compress.c: In function '_sx_compress_wio':
compress.c:141: warning: 'return' with no value, in function returning non-void
compress.c: In function '_sx_compress_rio':
compress.c:202: warning: 'return' with no value, in function returning non-void

I'm not very familiar with this code, so please check to make sure my change is correct. The comment in sx.h says, "return -2 == failed (permanent), -1 == failed (temporary), 0 == handled, 1 == pass" It looks like the two functions are returning because compression is not enabled, in which case it seems like they should "pass" and the next function in the chain should attempt to read or write the data?

Attachments

jabberd_fix_2_compile_warnings.diff (0.6 kB) - added by markdoliner 11 months ago.

Change History

Changed 11 months ago by markdoliner

Changed 11 months ago by smoku

  • status changed from new to closed
  • resolution set to fixed

(In [439]) Fixes #167 function return values for compress rio/wio.

Note: See TracTickets for help on using tickets.