Ticket #163 (closed defect: fixed)

Opened 14 months ago

Last modified 13 months ago

Patch: Fix a few missing calls to fclose and va_end

Reported by: markdoliner Owned by: smoku
Priority: major Component: General
Version: 2.1.17 Keywords:
Cc: Tracforge_linkmap:
Blocking: Blocked By:

Description

I found a few places where fclose() wasn't being called and a file descriptor could be leaked, and a few other places where va_start() was called but va_end() was not.

This patch also contains a few minor spelling fixes and one change to a call to xhash_new(). The parameter to xhash_new is a prime number everywhere else, but I found somewhere in the current code where "9" is used, so I changed it to 11. I have a feeling that the hashing algorithm used doesn't actually care if the number if prime, but I figured it would be good to be consistent.

Attachments

Change History

Changed 14 months ago by markdoliner

Changed 13 months ago by smoku

  • status changed from new to closed
  • resolution set to fixed

(In [432]) Fix a few missing calls to fclose and va_end. Fixes #163

Changed 13 months ago by smoku

IIRC older version of hashing algorithm used, required primes.

But I do agree - keeping it consistent could save us a surprise in the future.

Note: See TracTickets for help on using tickets.