Ticket #159 (closed defect: fixed)

Opened 11 months ago

Last modified 11 months ago

Patch: Fix configure check for OpenSSL version

Reported by: markdoliner Owned by: smoku
Priority: major Component: General
Version: 2.1.17 Keywords:
Cc: Tracforge_linkmap:
Blocking: Blocked By:

Description

configure.ac contains an AC_LANG_PROGRAM call that attempts to compile a basic openssl program and check that the version is new enough. It uses the SSLeay() function for this. The program includes the header <openssl/opensslv.h> for this, however all the evidence that I find says that this function is in <openssl/crypto.h>.

I checked the man page, I checked the header files in openssl-0.9.6b (downloaded from their web site), and I checked the header files in openssl-0.9.8c (installed on my system). I'm not sure how this works for other people... unless for some reason your opensslv.h includes crypto.h?

In any case, I believe the attached patch will work for everyone.

Attachments

jabberd2_fix_openssl_version_check.diff (0.6 kB) - added by markdoliner 11 months ago.

Change History

Changed 11 months ago by markdoliner

Changed 11 months ago by smoku

  • status changed from new to closed
  • resolution set to fixed

(In [428]) Fix configure check for OpenSSL version. Fixes #159

Changed 11 months ago by smoku

I believe that on standard Linux instalation the crypto.h header was pulled in as a dependency. But we should test what really should be tested.

There is a mess in header files, which I gradually clean up. Thanks for the patch.

Changed 11 months ago by markdoliner

I believe that on standard Linux instalation the crypto.h header was pulled in as a dependency.

That sounds right to me. I tested on a different distribution where I was able to compile without this change (CentOS 4 instead of Ubuntu Feisty Fawn)... I removed the #include line from the AC_LANG_PROGRAM() and it configured successfully. So it DOES look like crypto.h was being included regardless.

Note: See TracTickets for help on using tickets.