Discovering Active sessions does not work

[smoku]

When admin is doing disco against server, the “Active sessions” node is visible, but there is no reply for its subitems. Using Gajim here.

[smoku]

It's Gajim that is broken, not jabberd.

[Asterix]

There is a bug in jabberd:

according to the XEP jabberd answers badly to disco#info:

<iq to="server.net" type="get" id="770">
<query xmlns="http://jabber.org/protocol/disco#info" node="sessions" />
</iq>

<iq xmlns='jabber:client' id='770' from='server.net' to='login@server.net/Gajim' type='result'>
<query xmlns='http://jabber.org/protocol/disco#info'>
<identity name='Server.NET Jabber Server' type='im' category='server'/>
<feature var='jabber:iq:private'/>
<feature var='presence'/>
<feature var='jabber:iq:time'/>
<feature var='jabber:iq:agents'/>
<feature var='urn:xmpp:ping'/>
<feature var='http://jabber.org/protocol/vacation'/>
<feature var='vcard-temp'/>
<feature var='jabber:iq:version'/>
<feature var='message'/>
<feature var='msgoffline'/>
<feature var='jabber:iq:privacy'/>
<feature var='http://jabber.org/protocol/amp'/>
<feature var='jabber:iq:roster'/>
<feature var='iq'/>
<feature var='jabber:iq:last'/>
<feature var='http://jabber.org/protocol/disco'/>
</query>
</iq>

[smoku]

What exactly is buggy about this behavior?

Do you mean the 'node' attribute? It's only SHOULD

the response SHOULD mirror the specified 'node' attribute

And why the info query at all?

although the primary use of nodes is as Items Nodes rather than as info nodes

[nexus]

patch that will copy node attribute from request into response

[Asterix]

yep I was talking about the node attribute. It's indeed only a should, but Gajim track answer on that rather than on id number. And if you don't implement SHOULD-things, jabberd will be very light, there are a lot of them in XEPs :)

We query info before items to know if this node is browsable or not, searchable or not ... Node can have different features from server itself.

[smoku]

Replying to Asterix:

yep I was talking about the node attribute. It's indeed only a should, but Gajim track answer on that rather than on id number.

That stays contrary to the RFC3920 9.2.3. IQ Semantics: "the interaction is tracked by the requesting entity through use of the 'id' attribute."

And if you don't implement SHOULD-things, jabberd will be very light, there are a lot of them in XEPs :)

SHOULD-things are recommended to be implemented, but they are SHOULD-things and implementors cannot require them to be implemented - thus not implementing a SHOULD cannot be considered a bug. On the contrary to not following the RFC.

If you want jabberd to implement this SHOULD, please create an enhancement ticket.

[smoku]

(In [505]) Put node in disco#info reply if present. Refs #11