Changeset 691

Timestamp:

21/08/08 08:48:10 (3 months ago)

Author:

markdoliner

Message:

Fix a memory leak when a user signs off. I somehow managed to forget
to free the rate struct used for keeping track of how many stanzas
each user sends. This should have been done in revision 636. My bad.

The leaked memory isn't actually that bad (40 bytes per user, on a
64bit machine). But it results in some pretty bad memory fragmentation,
which causes malloc to perform increasingly slower until the server
is restarted.

Location:

trunk

Files:

• c2s/main.c (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/c2s/main.c

@@ -777 +777 @@
                 }
             if(sess->rate != NULL) rate_free(sess->rate);
+            if(sess->stanza_rate != NULL) rate_free(sess->stanza_rate);
 
             free(sess);

trunk/ChangeLog

@@ +1 @@
+2008-08-21 Mark Doliner <mark@meebo.com>
+        * Fix a memory leak when using stanza rate limiting
+
 2008-08-09 Tomasz Sterna <tomek@xiaoka.com>
         * Sending stream errors on SX wrapper errors